Aug 25, 2017 · 1 min read
Hi!
Overally great article, just some neatpicks here:
- yield [] is deprecated in favor of yield all([]), it would be nice to use it in the new articles :)
- this is an infinite loop:
/* We create an orchestrator saga */
function* orchestratorSaga () {
while (true) {
yield fork(fetchDataOverFiveDifferentLocations)
}
}as fork is not a blocking-effect
- `for/of` loop can be omitted really with something like:
yield all(events.map(event => put({type: 'some_action', payload: event})))