recap 2018–03 — What happened in the OpenMage Project

Daniel Fahlke
2 min readApr 28, 2018

--

Naming things is hard, like this Blogpost. Its actually 04, but I did not write one since 01. I wanted to name it Q1, but that would mix up with 01.
And as I saw, most commits were merged in 03, I now took this.

Also as I did not get so many Views on this posts yet, and also it seems I will not get much support for this via my patreon https://www.patreon.com/Flyingmana
So I will reduce this to one Post per quarter for now.

So what did actually happen

Don’t allow quoted-string email format.
* https://github.com/OpenMage/magento-lts/issues/378

Fix retrieval of payment child transactions
* https://github.com/OpenMage/magento-lts/pull/440

Fix for Mage_Core_Controller_Varien_Exception::prepareRedirect
* https://github.com/OpenMage/magento-lts/pull/462

Import of 1.9.3.8

Session validation failure
* https://github.com/OpenMage/magento-lts/issues/394
* https://github.com/OpenMage/magento-lts/commit/36a0afb8937fd6c358c507b3a59b7cf119fc3e8b

PHP 7.2 Fixes (method signature)
* https://github.com/OpenMage/magento-lts/pull/450

[PHP-7] fix memory leak
* https://github.com/OpenMage/magento-lts/pull/451

Fix rounding bug
* https://github.com/OpenMage/magento-lts/commit/2952af7ec112d8c58e7f300f619cb44d499c573f

Fix 1.8 regression: Ensure StockId is set before saving cataloginventory/stock_item
* https://github.com/OpenMage/magento-lts/commit/b098b2153a9f99510dbb34460ede7a2965025081

Cast handling fee to float
* https://github.com/OpenMage/magento-lts/commit/c270fb84b501ca601cf95068a87dedf7e5c0accd

catalog pricerules start and end date not respected
* https://github.com/OpenMage/magento-lts/pull/444
* https://github.com/OpenMage/magento-lts/issues/443

Fixes undefined classes
* https://github.com/OpenMage/magento-lts/pull/418

Use describeTable and then use prepareColumnValue to actually prepare the value being used in the where section of select statements
* https://github.com/OpenMage/magento-lts/pull/383

Fix admin create order shipping_as_billing is 0
* https://github.com/OpenMage/magento-lts/pull/306

Make gender translatable
* https://github.com/OpenMage/magento-lts/pull/243

SUPEE 7136 addition - change seassion cookie to http-only
* https://github.com/OpenMage/magento-lts/pull/236

Fix possible option id/label collisions in getOptionId()
* https://github.com/OpenMage/magento-lts/pull/109

Add option reindexallrequired
* https://github.com/OpenMage/magento-lts/pull/184
* https://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue

add Sitemap dispatch event for add custom data
* https://github.com/OpenMage/magento-lts/pull/248
* https://github.com/OpenMage/magento-lts/pull/468 (renaming it)

Fixes issue with wysiwyg editor re-creating thumbnails
* https://github.com/OpenMage/magento-lts/pull/261

Typo in Product.php
* https://github.com/OpenMage/magento-lts/commit/4bb045f9657d02f3d891abe818b7e9a26838fa65

Missing hidden tax (will cause paypal to generate fraud error)
* https://github.com/OpenMage/magento-lts/commit/1e29f23a51a9da1f44224b484f8b108f79b0cd9f

Fix date selection when current date is disabled
* https://github.com/OpenMage/magento-lts/pull/327

Use FONT_HELVETICA intsead of LinLibertineFont in PDF
* https://github.com/OpenMage/magento-lts/pull/425

send PayPal new account mail in correct language
* https://github.com/OpenMage/magento-lts/pull/463

So we got quite a bit of Patches merged in this timeframe. Some very nice ones I have to say.
It can be even more, if we get a few more volunteers to do Reviews.

--

--

Daniel Fahlke

#php #magento #composerphp and also a lot of annoying random #stuff - Likes to be the advocatus diaboli - also http://m.atchuup.com/how-to-understand-introver