Pull Request Two
For my second pull request i worked on OpenStreetMap project. The goal of this project is to maintain a canonical list of commonly used names for suggesting consistent spelling and tagging of features in OpenStreetMap.
How it’s used
When features are created in OpenStreetMap, the names and tags are always not consistent. For example, we may prefer
McDonald's tagged as
amenity=fast_food but we see many examples of other spellings (
McDonald’s) and taggings (
Building a canonical name index allows two very useful things:
- We can suggest the most “correct” way to tag things as users create them while editing.
- We can scan the OSM data for “incorrect” features and produce lists for review and cleanup.
Your essentially researching brands and giving a tag.
Steps i took to get it done:
Once i got it set up. I opened it in Visual Studio. when in to name-suggestion-index. I run
I followed instrution in the issue. I went in to
brand/shop/shoes/shoes.json. I had to find Journey tag. I then added “brand:wikidata”: “Q7079121” and “brand:wikipedia”: “en:Office Holdings”. I then run
npm run buil to make sure there are no errors. I finally,
git push issue-1614 to my forked repo.
🤔 We need help deciding what to do with "shop/shoes|Office" 👉 Read the CONTRIBUTING.md guide for more info, and feel…github.com
Canonical common brand names for OpenStreetMap. Contribute to osmlab/name-suggestion-index development by creating an…github.com