Sep 7, 2018 · 1 min read
I disagree that the responsibility for resolving conflicts should be on the reviewer. I think it should be the responsibility of the developer submitting the pull request to ensure their changes are up to date with the current state of the repository. Code reviews should be about whether the code works as intended, is written clearly and efficiently and aligns with the code standards set by the project lead. If the code cannot be pulled into the main branch, doesn’t compile or fails tests then it shouldn’t even reach review.
