The entire point of Hadrian’s wall was to stop tribal attacks. Full-scale attacks by large bands of armed and dangerous men that could penetrate at will all along the border. Bit of a different situation with Mexico, isn’t it?

Trumps wall would work fine. Your points about maintenance, manpower requirements, and border towns are well-taken, but I think your overall point is very flawed.