You should be careful and not let any contract subscribe to the events to avoid security issues
Adrián Calvo
11

Hey Adrian, good catch! We actually have modifiers on all of these methods in the RP repo to make sure that tx are only coming from allowed origins etc:

https://github.com/rocket-pool/rocketpool/blob/master/contracts/contract/utils/pubsub/Publisher.sol#L60

https://github.com/rocket-pool/rocketpool/blob/master/contracts/RocketPool.sol#L82

I’ve just removed them in the example gists to make the code a little easier to follow and make sure it doesn’t overwhelm readers who don’t want to dive too deep into it ;)