Aug 31, 2018 · 1 min read
Hey, glad that you liked the article!
What I mean is:
- Danger expects to find some specific ENV variables that are usually being injected by plugins like Github Pull Request Builder plugin and also expects to find a “CI” ENV variable. While one might say “ok why don’t you inject them then?”, I think that it does not worth the manual effort of doing so. We first tried that approach and we had success on making it run but the implementation was not ideal and certainly would not scale, should we need more things to add.
- Danger also includes functionality that appropriately changes Commit state on Github. If it was not expecting an ENV variable containing the pull request ID, we could supposedly use it just for the commit’s state.
