Code Reviews Considered Harmful

I think another important question with code reviews is whether you can commit code and have the code review done later. I’ve worked in companies that allows this and in companies that prohibit this.

I’ve found that not having to wait for code reviews is great when you have a smaller team of responsible engineers that can decide whether a change can be reviewed later or needs pre-commit review. In the case of post-commit reviews, knowing that someone will still see your code makes you write great code, but you’re not blocked on a code review. And if the person reviewing your code finds a bug, they’ll let you know and you’ll correct it.

One clap, two clap, three clap, forty?

By clapping more or less, you can signal to us which stories really stand out.