Why I Don’t Immediately Use “Require Changes” on PR’s

Trust

Christian Thomas
Jul 28, 2017 · 2 min read

I have yet to encounter a co-worker who is totally dismissive of my comments on a review. I trust that if I say something they will respond to it in a change or comment providing rationale.

Communication

I’d much rather have you figure out what you need to change, what’s worth changing, and what’s just my opinion by how we talk to each other. Part of my job is to communicate the value my proposed change has. Blocking a PR immediately isn’t the same as saying “this needs to change before production, but I want to help you see why.” It can be a way of saying, “I don’t care what you think, stop all your horses.”

Phrases like “consider this” or “non blocker, but…” is part of how I comment on non-essentials. If something is going to break and I know why, I’ll usually just say “that will break this thing, here’s probably how to do what you wanted.” I haven’t encountered anyone who wants to deploy a break when someone literally tells them it will break.

It Comes Off Assy Sometimes

Instant checkmate. Appease me, the ultimate authority or else. In the hands of someone with little trust and communication with teammates, this tool starts to act like a weapon or a hill to hide behind. It becomes a toxic feature. If we’re shooting for fairly egalitarian process this doesn’t work. Even in the case that an architect has to approve changes, it’s not always necessary. That said, if something is going critically wrong on a PR, I’ll use it. Otherwise, trust and communication have gotten me a long way in helping someone make their PR as best as we both possibly can.

Christian Thomas

Written by

I am Mr. Christian. You don't even have to respect me. Software Engineer@adobe http://christianthomas.me

Welcome to a place where words matter. On Medium, smart voices and original ideas take center stage - with no ads in sight. Watch
Follow all the topics you care about, and we’ll deliver the best stories for you to your homepage and inbox. Explore
Get unlimited access to the best stories on Medium — and support writers while you’re at it. Just $5/month. Upgrade