Handling the inevitable — II

Apart from test cases and code coverage, code review plays an equally important role in the success of a PBI or a bug.

P.C: Google

At the outset, development teams should ensure that code changes are always made in feature branches, code should not be merged to the release branch without the reviewers approving it and pull request is raised with the tech lead and architect as the required reviewers.

The focus areas could be :

• The implementation is as per the proposed architecture
• The code is clear, concise and logically correct
• The acceptance criteria is met
• The code coverage has not dropped
• Sufficient unit test cases are written
• Errors, exceptions and information is logged
• Exceptions are thrown and not eaten
• Comments are written where ever required
• Dead, duplicate, unused, commented out code is removed
• Naming conventions are followed
• Code aligns correctly when multilined
• Nulls checked for the loops
• Edge cases covered
• Memory is cleared post usage
• Only required permissions are provided

The reviewers should add the comments and the developers should resolve them and re-commit the code.

The branches should not be deleted post merge and should be kept for reference.

Well maintained code under test driven development goes a long way.