AGILE | PULL REQUEST | CODE REVIEW
How to Get Useful Code Reviews
And common code review problems
You are a junior in a team of developers. Recently joined, and don’t know about pull requests.
The first code task is done. Who should review the code? How does junior pick the right reviewers?
Other problems arise. Junior doesn’t know the experts. Doesn’t even know the team that well.
Junior writes code. Does code adhere to a team convention?
When issues occur. You get the PR ready. Then we wait.
Why do we wait so much? Notify others, but still, PR is in review.
What is the problem with review time? Why isn’t it reviewed immediately? What’s blocking the review?
You expect comments on your review. You get low-level adjustments³. Most likely you get comments with no code trigger. You get pointless comments⁶, such as “Why did you do it like this?”
You expect defects to be found. Yet a lot of them slip through.
Concerning surveyed developers/testers, finding defects is the first motivation for code review for 383 of the programmers (44%), second motivation for 204 (23%), and third for 96 (11%)³
