Finishing up for Phase 2
Phase 2 was great , i learnt a great deal on how to plan and execute correctly , how to apply design principles , how to make codebase flexible from my mentors . Last week we fixed some trivial issues and fixed them quickly and also thought about some changes we need to make to test suite of hydrus , specially test_crud.py .
There was this issue in hydrus where in the entrypoint “@id” field there were more than one _: , I fixed it quickly by putting a conditional statement which checked if the @id had more than one _: and removed the extra one . Pretty basic .
The hydra api doc generated by the parser was failing the tests ! Firstly this should not have happened because there is no way the doc would fail the tests as it was made using the doc_writer . On close inspection we found out that the tests we made specifically to test the doc_maker and hence hardcoded at a lot of places . We could not use any doc with the existing tests , we could only use the doc created via doc_maker . We have opened an issue for this , we need to generalise the test suite to test any hydra api doc .
The PR’s merged this week are :
