Weekly Dev Update #66
THORChain Weekly Dev Update for Week 66, 21–26 Oct; Removal of 24hr liquidity limit, LastObserved for each Node, Auto-restart for Binance and more.
Summary
The team worked on Chaosnet stability, testnet fixes, and multi-chain tweaks. Midgard was also updated.
Removal of 24hr TimeLimit on Liquidity
With “confirmation counting” now implemented for PoW chains, the timelimit for adding liquidity can be removed. It was only added as a blanket solution to allow liquidity providers of any chain to deposit assets into pools, and be credited their liquidity immediately.
Instead, the team (to reduce complexity) pushed logic for conf-counting back to the Bifrost level, so it will count confirmations prior to telling THORChain about a new event. This means when users add liquidity in large amounts they will be delayed if they exceed the block rewards for that block.
For instantly final chains conf-counting is not necessary.
LastObserved
When a node makes a witness transaction they will now include the blockheight of the event. This will update a new parameter on each node “last observed” on a per-chain basis. This will allow dashboards to be built that can easily show the sync status of all nodes at any time — if they are up to date then they will show the same last observed for each chain. If they are offline (or just have a single chain client crashed) then bots and alert services can easily compare and notify.
Releases
Midgard V0.4.0 was released with some improvements and updates. Details below.
THORNode
The team deployed a fixes for testnet vault management, as well as multi-chain bug fixes found on mocknet.
- allow the build to still tag with BRANCH(testnet-multichain), however tag will be `testnet`
- update go-tss
- [FIX] bug on multichain-testnet filtered txin item get bundle with unfiltered , as a result unfiltered txin item escaped filtering
- Update testnet multichain
- Update for new midgard simple semver
- Update CI midgard simple semver
- Resolve “[FIX] Save all the in memory on deck txin item to key value store”
- Resolve “ADD: LastObservedHeight to nodeaccounts”
- set StakeLockUpBlocks to 0
- update swap slip formula
- [bugfix] specifying query height no longer persists across queries
- Resolve “[FIX] allow bifrost to spent more than BTC min-relay fee on gas”
Midgard
Fixes and tweaks for stability, as well as releasing V0.4.0.
- Resolve “FIX: poolAPY nodeAPY”
- Resolve “Midgard prioritize the manually “pool” status event”
- Resolve “BUG: Invalid catching_up value when Midgard is synced”
- Resolve “ADD: cache /v1/assets endpoint”
- Add Semver
- Resolve “BUG: Midgard should store output tx for refunded swap transactions”
- Resolve “Documentation issue. Buy volume listed as in Asset.”
- Fix refunded swap event
- Update CI
- Resolve “Update Midgard api doc version to 0.4.0”
- Resolve “ADD: poolAPY to simple view of /v1/pools/detail”
Devops
A major feature shipped was an auto-restart to Binance client, which should fix any reliability issues going forward.
- Update multi-chain config
- Expose binance RPC publicly with rate limit
- Add step-by-step instructions on setting up PagerDuty, Dead Man’s Snitch, and Slack
- update midgard to use 0.4.0 tag
- Tweak midgard resources
- Add probe for timescaledb
- Ignore cache header on thor-api
- Add sleep after pull
- Add auto recover binance on restarts
- Fix reset-binance with recover auto
Clients
BEPSwap Client
Numerous UI/UX tweaks based on community feedback
ASGARDEX Client
Work continues to prepare the client for Chaosnet. Bitcoin and Ethereum have been integrated.
Community Work
The following tools receive regular updates:
RUNEStake
Telegram Bot
Twitter Bot
Delphi Defi Dashboard
https://defi.delphidigital.io/thorchain/chaosnet/network
THORChain Network Explorer
THORChain Official Block Explorer
https://viewblock.io/thorchain
Audits
A final security audit is being completed.
Next Milestones
Bitcoin public testnet.
Community
To keep up to date, please monitor community channels, particularly Telegram and Twitter:
- Twitter: https://twitter.com/thorchain_org
- Telegram Community: https://t.me/thorchain_org
- Telegram Announcements: https://t.me/thorchain
- Reddit: https://reddit.com/r/thorchain
- Github: https://github.com/thorchain
- Medium: https://medium.com/thorchain