webpack freelancing log book (week 1)
2017/04/03 — 2017/04/09
Busy reviewing and merging PRs on webpack/webpack. Revived some older PRs. Closed some outdated webpack-1 PRs.
Established a nice bot-assisted PR process labeling system. All labels are automatically added and removed by the bot.
Yes webpack has a bot now. 🎉
PRs start with unreviewed and continue to reviewed-changes-requested after a review. When the PR author adds additional commits they change to review-outdated . After an review they change back to reviewed-changes-requested or reviewed-approved. This way the reviewer can easily look for review-outdated to continue started reviews or look for new stuff to do (unreviewed )
In addition to that the bot will work with the PR author to fix CI failures. It posts a comment with the mocha results when the tests fail. It posts a result with the linting errors if the linting fails. It post a generic comment pointing to the CI results if the CI fails and it doesn’t know why (should be rar). It also comments with hints if the code coverage of the PR is too low, explaining when tests are needed and why, and pointing the user to the tests README. It also labels the PRs with CI-ok or CI-not-ok and/or tests-needed for a easy overview in the PR list.
I hope this process will reduce the load on the PR reviewers and improve the PR process. It already simplified it for me and I could cut the number of PRs in half in the first week.
I working on creating a similar workflow for issues, but for this I need scheduled actions for the bot (automatic closing after inactivity).
Pretty happy with the first week 😄
Plan for next week
Continue to merge the more difficult PRs. Most of them need additional changes by me.
Some of them are conflicting with each other… That’ll be fun. 😵
I also want to release a version 2.4 which include the latest changes.
